feat: propagate custom annotations to listener pod#4389
Open
kacperduras wants to merge 1 commit intoactions:masterfrom
Open
feat: propagate custom annotations to listener pod#4389kacperduras wants to merge 1 commit intoactions:masterfrom
kacperduras wants to merge 1 commit intoactions:masterfrom
Conversation
kacperduras
requested review from
a team,
mumoshu,
nikola-jokic,
rentziass and
toast-gear
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, adding annotations to runner pods (e.g. karpenter.sh/do-not-disrupt) requires setting them in two separate places:
template.metadata.annotationsfor runner pods andlistenerTemplate.metadata.annotationsfor the listener pod. There's no single place to define annotations that apply to everything. This PR makes annotations set on theAutoscalingRunnerSetpropagate automatically to the listener pod, so you only need to configure them once:listenerTemplate.metadata.annotationsstill works as before and takes precedence - this change doesn't affect that path.The PR also adds documentation to values.yaml for
template.metadata, since the field already worked for runner pods but wasn't mentioned anywhere, leaving users to discover it by reading the source.Closes #3722